Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add man pages and progress bars to Arch Linux image #1537

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

ac-z
Copy link
Contributor

@ac-z ac-z commented Sep 9, 2024

This pull request brings the Arch Linux toolbx image in line with the other toolbx-provided images by providing man pages with the default install.

As of right now, it seems like every well-supported Arch Linux image available is a minimized install without man pages or visual enhancements enabled for pacman. This is great for containerized applications and CI, but this isn't so great for frequent users of Arch Linux in toolbx or distrobox.

I've been working around this problem for a long while by maintaining my own local dockerfiles, but I kind of expected this issue to be solved upstream by now. Since it looks like we're not going to get any more Arch Linux docker images from upstream (at least for a very long while), I figured this is the best place to stick this fix.

EDIT: I should also mention, this disables all of the NoExtract lines in the config, including the following:

NoExtract  = usr/share/help/* !usr/share/help/en* !usr/share/help/C/*
NoExtract  = usr/share/gtk-doc/html/* usr/share/doc/*
NoExtract  = usr/share/locale/* usr/share/X11/locale/* usr/share/i18n/*
NoExtract   = !*locale*/en*/* !usr/share/i18n/charmaps/UTF-8.gz !usr/share/*locale*/locale.*
NoExtract   = !usr/share/*locales/en_?? !usr/share/*locales/i18n* !usr/share/*locales/iso*
NoExtract   = !usr/share/*locales/trans*
NoExtract   = !usr/share/X11/locale/C/*
NoExtract   = !usr/share/X11/locale/compose.dir !usr/share/X11/locale/iso8859-1/*
NoExtract  = !usr/share/*locales/C !usr/share/*locales/POSIX !usr/share/i18n/charmaps/ANSI_X3.4-1968.gz
NoExtract  = usr/share/man/* usr/share/info/*
NoExtract  = usr/share/vim/vim*/lang/*
NoExtract  = etc/pacman.conf etc/pacman.d/mirrorlist

I think this is generally fine as not much size is added, and I do frequently use toolboxes for graphical programs with gtk docs, or vim. Not sure what the difference is with the locales, but I could pretty easily make some changes to still exclude the locale files if that's what's needed to get this merged.

Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/ce654503f01d469a82e726e7c4c47624

✔️ unit-test SUCCESS in 5m 22s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 42s
✔️ unit-test-restricted SUCCESS in 5m 25s
✔️ system-test-fedora-rawhide SUCCESS in 1h 34m 09s
✔️ system-test-fedora-40 SUCCESS in 1h 33m 29s
✔️ system-test-fedora-39 SUCCESS in 1h 38m 07s

images/arch/Containerfile Outdated Show resolved Hide resolved
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/35cae01a568d4626a007a814a1873370

✔️ unit-test SUCCESS in 6m 16s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 21s
✔️ unit-test-restricted SUCCESS in 6m 16s
✔️ system-test-fedora-rawhide SUCCESS in 1h 37m 29s
✔️ system-test-fedora-40 SUCCESS in 1h 37m 05s
✔️ system-test-fedora-39 SUCCESS in 1h 40m 00s

@ac-z ac-z requested a review from Foxboron September 12, 2024 20:44
images/arch/Containerfile Outdated Show resolved Hide resolved
@Foxboron
Copy link
Collaborator

@ac-z Please squash all the commits into one :)

@Foxboron
Copy link
Collaborator

Foxboron commented Sep 13, 2024

@debarshiray the CI seems stuck?

Seems like it spent an hour, all good now.

Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/19e38fb6a5394bf2b8869ce515e561aa

✔️ unit-test SUCCESS in 5m 32s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 34s
✔️ unit-test-restricted SUCCESS in 5m 43s
✔️ system-test-fedora-rawhide SUCCESS in 1h 39m 51s
✔️ system-test-fedora-40 SUCCESS in 1h 40m 17s
✔️ system-test-fedora-39 SUCCESS in 1h 42m 19s

@Foxboron Foxboron merged commit dcd4c43 into containers:main Sep 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants