feat!: Update Kubernetes client to v1 #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the K8s client to the recently released v1.0.0. This resolves all vulnerabilities reported for Foreman by `npm audit`, since the K8s client v1 switched from the deprecated `request` library to `node-fetch`. The most relevant code change is due to the new error classes used by the client, which no longer seem to expose request headers like before, so we are able to simplify our request logic quite a bit. However, to avoid future regressions, the test code is modified to recurse through the errors and check for anything suspicious. BREAKING CHANGE: Kubernetes client v1 requires HTTPS for connecting to the Kubernetes API server. While this should not cause any problems in practice, as Kubernetes API servers are typically exposed over HTTPS, it would still break non-standard HTTP-only setups.
meyfa
force-pushed
the
feat/k8s-client-v1
branch
from
d8805c3 to
5b7ce88
Compare
lusu007
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the K8s client to the recently released v1.0.0.
This resolves all vulnerabilities reported for Foreman by
npm audit, since the K8s client v1 switched from the deprecatedrequestlibrary tonode-fetch.BREAKING CHANGE: Kubernetes client v1 requires HTTPS for connecting to the Kubernetes API server. While this should not cause any problems in practice, as Kubernetes API servers are typically exposed over HTTPS, it would still break non-standard HTTP-only setups.
Replaces #187
Additional Context
The most relevant code change is due to the new error classes used by the client, which no longer seem to expose request headers like before, so we are able to simplify our request logic quite a bit. However, to avoid future regressions, the test code is modified to recurse through the errors and check for anything suspicious.
Checklist
feat: Add social login