Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Require Node.js v22.12.0 or later #189

Merged
merged 1 commit into from
Dec 23, 2024
Merged

chore!: Require Node.js v22.12.0 or later #189

merged 1 commit into from
Dec 23, 2024

Conversation

meyfa
Copy link
Member

@meyfa meyfa commented Dec 23, 2024

We already build the Docker image with Node.js 22. It makes sense to run the CI tests with the same version, and restrict non-containerized installations to v22 as well.

This is especially important since v22.12 added require() of ESM modules, which may greatly impact an application's run-time behaviour.

Additional Context

N/A

Checklist

  • The pull request title meets the Conventional Commits specification and optionally includes the scope, for example: feat: Add social login

We already build the Docker image with Node.js 22. It makes sense to
run the CI tests with the same version, and restrict non-containerized
installations to v22 as well.

This is especially important since v22.12 added `require()` of ESM
modules, which may greatly impact an application's run-time behaviour.
@lusu007 lusu007 merged commit af7ef37 into main Dec 23, 2024
4 checks passed
@lusu007 lusu007 deleted the chore/node-22 branch December 23, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants