Fixes 3353: Snapshot inconsistent for API/UI #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrewgdewar
changed the title
Andrewgdewar
changed the title
Andrewgdewar
commented
Feb 6, 2024
| @@ -863,8 +863,6 @@ func (suite *ReposSuite) TestFullUpdate() { | |||
| }, nil) | |||
| suite.reg.RepositoryConfig.On("Update", test_handler.MockOrgId, uuid, expected).Return(false, nil) | |||
|
|
|||
| mockTaskClientEnqueueIntrospect(suite.tcMock, "https://example.com", repoUuid) | |||
There was a problem hiding this comment.
This test was presuming that the enqueue task would happen if the URL was not updated.
With this change, this was necessary to remove from the test.
|
lgtm |
rverdile
reviewed
Feb 7, 2024
|
/retest |
1 similar comment
|
/retest |
Andrewgdewar
force-pushed
the
HMS-3353
branch
from
29f2874
to
575f2ae
Compare
|
/retest |
rverdile
reviewed
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Snapshot create-on-edit is inconsistent between API and UI
This was caused by the URL not being checked correctly before enqueueing snapshot/introspect tasks.
This card corrects that issue.
Testing steps
Without this change, introspection/snapshot tasks will always be enqueued.
With it, the tasks will correctly, be ignored, as those two tasks are contingent on a URL change.