-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes 4742: snapshot and bulk delete endpoints and task #845
Open
dominikvagner
wants to merge
5
commits into
content-services:main
Choose a base branch
from
dominikvagner:4742
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,011
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikvagner
changed the title
Fixes 4742: add delete snapshot and bulk delete endpoints and task
Fixes 4742: snapshot and bulk delete endpoints and task
Oct 11, 2024
rverdile
reviewed
Oct 17, 2024
rverdile
reviewed
Oct 29, 2024
db/migrations/20241011124850_add_deleted_at_to_snapshots.up.sql
Outdated
Show resolved
Hide resolved
rverdile
reviewed
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm noticing an issue you can reproduce like this:
- Create a repository, change the URL to get 2 snapshots.
- Delete the more recent snapshot.
- In the UI, if you try to view the snapshots you'll see "No snapshots yet". I believe because in the API, if you fetch the repository,
last_snapshot_uuid
is omitted from the response.
rverdile
reviewed
Oct 29, 2024
rverdile
reviewed
Oct 29, 2024
rverdile
reviewed
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing steps
http DELETE :8000/api/content-sources/v1.0/repositories/${REPO_UUID}/snapshots/${SNAP_UUID}