-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HMS-4934: Add modules to introspected data #922
Open
jlsherrill
wants to merge
1
commit into
content-services:main
Choose a base branch
from
jlsherrill:modstream
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlsherrill
changed the title
Fixes 4932: Add search module streams
Fixes HMS-4932: Add search module streams
Dec 17, 2024
jlsherrill
changed the title
Fixes HMS-4932: Add search module streams
Fixes HMS-4934: Add modules to introspected data
Dec 18, 2024
jlsherrill
changed the title
Fixes HMS-4934: Add modules to introspected data
HMS-4934: Add modules to introspected data
Dec 18, 2024
jlsherrill
force-pushed
the
modstream
branch
from
December 20, 2024 21:39
a3c0075
to
b276d0d
Compare
/retest |
@jlsherrill this failed to build |
@swadeley yes, it will fail to build until content-services/yummy#31 is merged and i update it to use the new yummy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds module streams as searchable for introspected repos
Testing steps
go get ./...
make db-migrate-up
make repos-import
go run cmd/external-repos/main.go introspect go run cmd/external-repos/main.go introspect https://cdn.redhat.com/content/dist/rhel8/8/x86_64/appstream/os
go run cmd/external-repos/main.go introspect go run cmd/external-repos/main.go introspect https://cdn.redhat.com/content/dist/rhel9/9/x86_64/appstream/os
feel free to play with the search and rpm_names