-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API 24 and tasks docs #176
base: main
Are you sure you want to change the base?
Conversation
Add manifest tasks to sidebar nav.
Add Python
Add JavaScript
Add Node.js
Add cpp.
🚀 Deployed on https://deploy-preview-176--cai-open-source.netlify.app |
https://deploy-preview-176--cai-open-source.netlify.app/docs/tasks/build/?lang=python : Otherwise, LGTM. |
I'm not sure what wasm support means with the check boxes. The almost the entire SDK supports wasm. The only major gap is openSSL signing and verification for ES512. Does that column mean JavaScript? |
@cdmurph32 I'm not sure what you're referring to, perhaps the Rust release notes...? That's not part of this PR. I'm asking you to review these pages:
In particular, "Getting resources" needs something! The relevant files in the PR are:
|
Oops, that whole section was essentially a duplicate of the previous code block, that I forgot to remove.... I deleted it, so it should look better now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This setup works, but I think it would be useful to demonstrate how to include the library when installed locally (e.g. via npm
). For the library itself, that just looks like:
import { createC2pa } from 'c2pa':
But it gets a little tricker for the wasmSrc
and workerSrc
, which need to be made available as static assets that can be fetched at runtime. The best way to do that will vary depending on the build system. For example, vite has an "explicit URL imports" feature that we use in our minimal-ts-vite
example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I added this, see https://deploy-preview-176--cai-open-source.netlify.app/docs/tasks/setup/?lang=js
For nodejs: https://deploy-preview-176--cai-open-source.netlify.app/docs/tasks/setup/?lang=node
https://deploy-preview-176--cai-open-source.netlify.app/docs/tasks/read/?lang=node
https://deploy-preview-176--cai-open-source.netlify.app/docs/tasks/build/?lang=node
https://deploy-preview-176--cai-open-source.netlify.app/docs/tasks/get-resources/?lang=node
cc @cdmurph32 |
Changes in this pull request
Clarify and document new API and add manifest tasks.
Developers should review the languages that they work on. Do we need further reviewers?
For information on where all the files are, see Notes at the bottom of this description.
Rust
@gpeacock and @andrewhalle to review
C++
@gpeacock to review
Python
@tmathern to review
JavaScript
@emensch to review
Node.js
@cdmurph32 to review
Notes
To make reviewing easier for developers, I moved all the code into separate files in the
docs/tasks/includes
directory:_javascript-*.md
_cpp-*.md
_node-*.md
_python-*.md
_rust-*.md
Each language has four files, one for each task:
*-setup.md
*-read.md
*-get-resources.md
*-build.md