Mux app: Fix render error while creating/removing captions #9860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for ecommerce-app-base-components pending review.Visit the deploys page to approve it
|
Pintorado
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #7808
This PR fixes a re-render error that occurs when a captions is being added/removed.
Approach
Currently, the plugin triggers a full re-render of the player, which causes issues with the Mux Player library and leads to CORS errors.
The approach taken in this PR is to reload the player's manifest with the updated captions, without requiring a full re-render.
Recording
video.mp4
Testing steps
Create a content model with the Mux JSON Object. Then, create a new entry for that content type, and you’ll be able to test uploading assets.
After uploading an Asset, create a caption using the form in the field. Also test removing a caption.
The player should reload without errors.
Breaking Changes
None.
Dependencies and/or References
None.
Deployment
None.