Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect typing for unresolved links for taxonomy [] #2401

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

luizfonseca
Copy link
Member

Summary

  • Fixes the typing for Link objects from the taxonomy API. They are returned as "UnresolvedLinks" (where the parent key is sys)

Description

  • Change Link type to UnresolvedLink in types/concept.ts and types/concept-schemes.ts

Motivation and Context

  • Incorrect typing would lead to incorrect handling of the response objects.

Todos

  • N/A

Screenshots (if appropriate):

  • N/A

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@luizfonseca luizfonseca self-assigned this Dec 12, 2024
@luizfonseca luizfonseca requested a review from a team as a code owner December 12, 2024 16:13
@luizfonseca luizfonseca enabled auto-merge (squash) January 7, 2025 14:27
@luizfonseca luizfonseca merged commit f19c8bc into master Jan 7, 2025
7 checks passed
@luizfonseca luizfonseca deleted the fix/taxonomy-typing branch January 7, 2025 16:17
@contentful-automation
Copy link
Contributor

🎉 This PR is included in version 11.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants