Update README requrie-custome-rendering #112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevePhuc
changed the title
sbezludny
reviewed
Aug 8, 2019
sbezludny
approved these changes
Aug 8, 2019
sbezludny
suggested changes
Aug 8, 2019
| @@ -111,7 +111,7 @@ documentToHtmlString(document, options); | |||
| // -> <custom-paragraph><custom-bold>Hello</custom-bold><u> world!</u></custom-paragraph> | |||
| ``` | |||
|
|
|||
| Last, but not least, you can pass a custom rendering component for an embedded entry: | |||
| Last, but not least, if you use `EMBEDDED_ASSET` or `EMBEDDED_ASSET` you must pass a custom rendering component for render them: | |||
There was a problem hiding this comment.
Suggested change
| Last, but not least, if you use `EMBEDDED_ASSET` or `EMBEDDED_ASSET` you must pass a custom rendering component for render them: | |
| Last, but not least, if you use `EMBEDDED_ENTRY` or `EMBEDDED_ASSET` you must pass a custom rendering component for render them: |
There was a problem hiding this comment.
thank you for fixing, my mistake
| @@ -116,7 +116,7 @@ documentToReactComponents(document, options); | |||
| // -> <p class="align-center"><p class="bold">Hello</p><u> world?</u></p> | |||
| ``` | |||
|
|
|||
| Last, but not least, you can pass a custom rendering component for an embedded entry: | |||
| Last, but not least, if you use `EMBEDDED_ASSET` or `EMBEDDED_ASSET` you must pass a custom rendering component for render them: | |||
There was a problem hiding this comment.
Suggested change
| Last, but not least, if you use `EMBEDDED_ASSET` or `EMBEDDED_ASSET` you must pass a custom rendering component for render them: | |
| Last, but not least, if you use `EMBEDDED_ENTRY` or `EMBEDDED_ASSET` you must pass a custom rendering component for render them: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#58
Add to make it clean that it is required if you use
EMBEDDED_ASSETorEMBEDDED_ASSETin rich text