add strict null checks warning, remove unused tsconfig

continuedev · Nov 25, 2024 · a9c0dec · a9c0dec
1 parent 093cddb
commit a9c0dec
Show file tree

Hide file tree

Showing 8 changed files with 434 additions and 38 deletions.
diff --git a/.eslintrc.shared.json b/.eslintrc.shared.json
@@ -4,8 +4,9 @@
     "ecmaVersion": 6,
     "sourceType": "module"
   },
-  "plugins": ["@typescript-eslint", "import"],
+  "plugins": ["@typescript-eslint", "import", "strict-null-checks"],
   "rules": {
+    "strict-null-checks/all": "warn",
     "@typescript-eslint/semi": "warn",
     "curly": "warn",
     "eqeqeq": "warn",

diff --git a/core/package.json b/core/package.json
@@ -5,7 +5,6 @@
   "scripts": {
     "test": "cross-env NODE_OPTIONS=--experimental-vm-modules jest --runInBand",
     "tsc:check": "tsc -p ./ --noEmit",
-    "build:npm": "tsc -p ./tsconfig.npm.json",
     "lint": "eslint . --ext ts",
     "lint:fix": "eslint . --ext ts --fix"
   },

diff --git a/core/tsconfig.json b/core/tsconfig.json
@@ -16,7 +16,8 @@
     "noEmit": true,
     "jsx": "react-jsx",
     "noEmitOnError": false,
-    "types": ["jest", "node"]
+    "types": ["jest", "node"],
+    "strictNullChecks": true
   },
   "include": ["./**/*.ts", "./**/*.js", "./**/*.d.ts"],
   "exclude": ["dist"]

diff --git a/core/tsconfig.npm.json b/core/tsconfig.npm.json
diff --git a/extensions/vscode/tsconfig.json b/extensions/vscode/tsconfig.json
@@ -9,7 +9,8 @@
     "strict": true,
     "esModuleInterop": true,
     "resolveJsonModule": true,
-    "types": ["mocha"] // This solves conflict between jest and mocha: https://github.com/cypress-io/cypress/issues/7435#issuecomment-631695007
+    "types": ["mocha"], // This solves conflict between jest and mocha: https://github.com/cypress-io/cypress/issues/7435#issuecomment-631695007
+    "strictNullChecks": true
   },
   "include": ["src/**/*", "../../core/**/*.ts", "../../core/**/*.d.ts"],
   // core/test uses @types/jest, which conflicts with @types/mocha

diff --git a/gui/tsconfig.json b/gui/tsconfig.json
@@ -16,9 +16,8 @@
     "noEmit": true,
     "jsx": "react-jsx",
     "noEmitOnError": false,
-    "types": ["vitest/globals"]
-    // Disabled for now since it's causing too many errors
-    // "strictNullChecks": true
+    "types": ["vitest/globals"],
+    "strictNullChecks": true
   },
   "include": ["src", "../src/util/messenger.ts"],
   "references": [{ "path": "./tsconfig.node.json" }]