Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier precommit hook, Update .prettierignore #2899

Closed
wants to merge 2 commits into from

Conversation

vadjs
Copy link
Contributor

@vadjs vadjs commented Nov 13, 2024

Description

  • Run prettier against the entire project
  • Update .prettierignore
  • Add prettier precommit hook

This PR doesn't contain any meaningful changes that affects code by any way.
Only automatic fixes committed.
Since this PR will be merged, the codebase will be always consistent.

In case of any conflicts you can:

  • Drop last commit (with prettier run)
  • Rebase dev into this branch
  • Run npx prettier --write .
  • Make commit

Checklist

  • The relevant docs, if any, have been updated or created

Screenshots

[ For visual changes, include screenshots. ]

Testing

Not needed due to no meaningful changes. CI process covers testing part here.

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for continuedev failed. Why did it fail? →

Name Link
🔨 Latest commit 61a199d
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/673b0c54d6c7d70008662114

@vadjs vadjs changed the title Update .prettierignore, add prettier precommit hook Add prettier precommit hook, Update .prettierignore Nov 14, 2024
@vadjs vadjs force-pushed the prettier-precommit-main branch from d6be253 to 931e3e7 Compare November 18, 2024 09:33
@vadjs vadjs force-pushed the prettier-precommit-main branch from 931e3e7 to 61a199d Compare November 18, 2024 09:43
@sestinj
Copy link
Contributor

sestinj commented Nov 20, 2024

@vadjs this is awesome, but to be perfectly honest it feels ill-advised to accept such a large diff that I won't be able to (without taking an unreasonable amount of time) actually scrutinize at all.

Better to just run the thing myself. I have taken the husky pre-commit though, and will run prettier myself to see this through. Thanks for taking the time!

@sestinj sestinj closed this Nov 20, 2024
@vadjs
Copy link
Contributor Author

vadjs commented Nov 21, 2024

Hi @sestinj,
I understand that, that why i proposed just to drop the huge commit and run the prettier script by yourself.
As other ption you can just cherry-pick the first commit. It's pretty small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants