-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clickable chat symbols #2975
Clickable chat symbols #2975
Conversation
❌ Deploy Preview for continuedev failed. Why did it fail? →
|
found one bug on this where react remark is using outdated state values grabbed during options initialization only, which causes it to only inject symbols into |
Bug fixed, ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works beautifully 👌
One nitpick - at a glance, it's somewhat difficult to tell which code highlights are clickable on my dark mode. On light mode it's quite easy to tell. Thinking the easy solution is just making the underline lighter/brighter when on dark mode.
I think adding an icon like the code-bracket
from hero icons could also be a nice touch, and would match the filename link with its language icon, but worried that would be a bit noisy.
--
Also, this is unrelated to your changes, but I noticed on light mode the hover effect for both the filename link and code symbols link are off
@RomneyDa also patched merge conflicts here partially related to my recent merge to main, take a second peek at my resolution though. |
This is amazing Few nitpicks as well, but I'd be more than happy to let this split up so we can merge and put in pre-release today what's already done
|
@Patrick-Erichsen thanks for the feedback, fixed the light/dark issues and switched to a simple opacity change on hovering |
|
ready for review |
Description
Classes and functions are retrieved and cached per file during context item retrieval. Markdown components can then check for matching symbols based on nearby context items. Only checks for full or
startsWith
matches within code elements. Will hallucinate occasionally but pretty reliable.https://www.loom.com/share/14827247cd8b48ab9473171df9df08f7