Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve the diff block logic for inline chat #3039

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

lkk214
Copy link
Contributor

@lkk214 lkk214 commented Nov 22, 2024

Description

  1. When the type of the first diff line is old, the inlay box is removed.
  2. When the type of the first diff line is new, it is displayed above the inlay box.
  3. Fixed IndexOutOfBoundsException when deleting the last row.

Screenshots

bug1

bug2

Testing

fix1
fix2

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for continuedev ready!

Name Link
🔨 Latest commit b4000e1
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/67408216be9f990008a88741
😎 Deploy Preview https://deploy-preview-3039--continuedev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Patrick-Erichsen
Copy link
Collaborator

Patrick-Erichsen commented Nov 22, 2024

Nice, these are awesome fixes! This has been bothering me too so I appreciate the contribution. The GIFs are also super helpful.

Just a heads up, we won't be able to release this right away unfortunately since we are currently pinned to 0.0.75 in JetBrains - see here for details. Planning to get a new version out in the coming weeks though.

@Patrick-Erichsen Patrick-Erichsen merged commit 2c37e9c into continuedev:main Nov 22, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants