Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance and redux audit #3061

Merged
merged 6 commits into from
Nov 27, 2024
Merged

Performance and redux audit #3061

merged 6 commits into from
Nov 27, 2024

Conversation

RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Nov 25, 2024

Description

  • Fix initial config load race condition logic
  • Move useSetup to a parallel component to prevent unnecessary rerenders of pages
  • Move VscThemeProvider and SubtextmenuContextProviders into a more isolated provider-hook paradigm
  • Fix some subtext menu context provider logic that was causing unnecessary renders
  • useSelector audit - cleanup/fix selectors that were causing renders on every run
  • fix logic that was causing config.showChatScrollbar to be ignored

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 5f32985
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/674771e1790a6d000832628f

@sestinj
Copy link
Contributor

sestinj commented Nov 27, 2024

Nice, things seem to work well!

I'm notorious for doing this myself, but as we lean more heavily on bisecting to find issues, probably good to attempt smaller commits during any refactor

@sestinj sestinj merged commit 09db8ce into main Nov 27, 2024
5 checks passed
@sestinj sestinj deleted the dallin/lag-audit branch November 27, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants