Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core <> GUI selected model sync #3163

Merged
merged 6 commits into from
Dec 5, 2024
Merged

Conversation

RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Dec 3, 2024

Core's selectedModelTitle was not always in sync with GUI's.

  • Changed so GUI always passes selectedModelTitle when relevant (only a few cases), and selected model is no longer stored on Core (removed "update/modelChange" message)
  • Added a few checks for if a model is selected

Note, originally Added "update/modelChange" messages all over until moving to only storing on GUI

@RomneyDa RomneyDa requested a review from sestinj December 3, 2024 06:26
Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for continuedev ready!

Name Link
🔨 Latest commit 1d93277
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/675105c641e4ea0008205300
😎 Deploy Preview https://deploy-preview-3163--continuedev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RomneyDa RomneyDa changed the title Core <> GUI default model sync Core <> GUI selected model sync Dec 5, 2024
@RomneyDa RomneyDa merged commit 3a7b5f9 into main Dec 5, 2024
5 checks passed
@RomneyDa RomneyDa deleted the dallin/default-model-selection branch December 5, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant