-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intercept Ollama errors before Webview, to display Download/Start options #3740
Conversation
…ions Signed-off-by: Fred Bricon <[email protected]>
✅ Deploy Preview for continuedev canceled.
|
I decided to remove the Documentation option shown during completion failure, when ollama is not started:
|
so actually this PR is based on top of #3725, leveraging the change in the respond signature (now allowing type So do not merge this before #3725, or else there will be a compilation error. |
Fixes #3674
Description
Ollama specific errors are intercepted in VS Code's webviewProtocol class, before they're propagated to the webview, so they can be treated the same way as in #3653, and allow users to start or download Ollama if needed.
Checklist
Screenshots
Before:

or, when #3725 is applied:

After:

Testing instructions