Fix CLI warnings #7275
Open
Fix CLI warnings #7275
+215
−519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
| @@ -145,6 +145,11 @@ function convertJsonSchemaToGeminiSchema(jsonSchema: any): GeminiObjectSchema { | |||
| export function convertOpenAIToolToGeminiFunction( | |||
| tool: ChatCompletionTool, | |||
| ): GeminiToolFunctionDeclaration { | |||
| // Type guard for function tools | |||
| if (tool.type !== "function" || !("function" in tool)) { | |||
There was a problem hiding this comment.
Guard should verify that tool.function is defined, not just that the property name exists
Prompt for AI agents
Address the following comment on packages/openai-adapters/src/util/gemini-types.ts at line 149:
<comment>Guard should verify that tool.function is defined, not just that the property name exists</comment>
<file context>
@@ -145,6 +145,11 @@ function convertJsonSchemaToGeminiSchema(jsonSchema: any): GeminiObjectSchema {
export function convertOpenAIToolToGeminiFunction(
tool: ChatCompletionTool,
): GeminiToolFunctionDeclaration {
+ // Type guard for function tools
+ if (tool.type !== "function" || !("function" in tool)) {
+ throw new Error(`Unsupported tool type: ${tool.type}`);
+ }
</file context>
Suggested change
| if (tool.type !== "function" || !("function" in tool)) { | |
| if (tool.type !== "function" || !tool.function) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the
npm warn deprecated [email protected]: Use your platform's native DOMException insteaderror that was showing up due to a dependency in openai version 4 by bumping to version 5. A few type guards were required to handle the new openai types safely. It also adds a few files to .npmignore.