Skip to content

Conversation

RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Oct 7, 2025

Description

Issue being that when it was overriding, the model would see the additional processed args in the chat history


Summary by cubic

Separates preprocessed tool arguments from parsedArgs so enhanced values don’t leak into chat history, and updates the UI to use processedArgs with safe fallbacks. Addresses Linear CON-4240.

  • Bug Fixes

    • Prevents preprocessed args from appearing in chat history seen by the model.
    • EditExistingFile, SingleFindAndReplace, and MultiEdit now read processedArgs (falling back to parsedArgs).
  • Refactors

    • Added processedArgs to ToolCallState.
    • Renamed setToolCallArgs to setProcessedToolCallArgs and updated preprocessToolCalls to use it.
    • Removed enhanceParsedArgs thunk; preprocessing is handled via processedArgs.

@RomneyDa RomneyDa requested a review from a team as a code owner October 7, 2025 00:12
@RomneyDa RomneyDa requested review from Patrick-Erichsen and removed request for a team October 7, 2025 00:12
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 7, 2025
Copy link

github-actions bot commented Oct 7, 2025

✅ Review Complete

Code Review Summary

⚠️ Continue configuration error. Please verify that the assistant exists in Continue Hub.


Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Oct 7, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 7, 2025
@Patrick-Erichsen Patrick-Erichsen merged commit 2f1ed97 into main Oct 7, 2025
70 of 73 checks passed
@Patrick-Erichsen Patrick-Erichsen deleted the dallin/con-4240-separate-preprocessed-args branch October 7, 2025 16:35
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Oct 7, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants