Skip to content

Conversation

@RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Nov 4, 2025

Description

Original author @etherandrius (Co-authored here).
#7343 was stale, addressed comments and reworked here.
See discussion on ^


Summary by cubic

Stop storing rule text in chat history and dev data. We now keep only rule metadata to reduce payload size and improve privacy, while keeping a quick way to open the full rule when needed.

  • Refactors

    • appliedRules now uses RuleMetadata (no rule text) across core and GUI.
    • getSystemMessageWithRules returns metadata; rule text is used only to build the system message.
    • Removed rule text from analytics payloads and schema.
    • Added useOpenRule and updated RulesPeek and RulesSection to open the rule source (default URL for default-* rules, file for others).
    • Updated getRuleId and rules-utils to work with RuleMetadata.
  • Migration

    • Remove any use of appliedRules.rule; open the source file or default URL instead.
    • Update types where appliedRules was RuleWithSource to RuleMetadata.
    • No user action needed; new chats no longer persist rule content.

Written for commit d7cc498. Summary will update automatically on new commits.

@RomneyDa RomneyDa requested a review from a team as a code owner November 4, 2025 20:43
@RomneyDa RomneyDa requested review from sestinj and removed request for a team November 4, 2025 20:43
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 4, 2025
@RomneyDa RomneyDa changed the title feat: (ft etherandrius) remove applied rules from chat history feat: remove applied rules from chat history Nov 4, 2025
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

✅ Review Complete

Code Review Summary

⚠️ Continue API authentication failed. Please check your CONTINUE_API_KEY.


Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 11 files

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Nov 7, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 7, 2025
@RomneyDa RomneyDa merged commit 577e748 into main Nov 7, 2025
56 of 58 checks passed
@RomneyDa RomneyDa deleted the dallin/remove-applied-rules-from-history branch November 7, 2025 20:53
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Nov 7, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2025
@github-actions github-actions bot added the tier 2 Important feature that adds new capabilities to the platform or improves critical user journeys label Nov 7, 2025
@sestinj
Copy link
Contributor

sestinj commented Nov 7, 2025

🎉 This PR is included in version 1.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer released size:L This PR changes 100-499 lines, ignoring generated files. tier 2 Important feature that adds new capabilities to the platform or improves critical user journeys

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants