Skip to content

Commit

Permalink
typo
Browse files Browse the repository at this point in the history
  • Loading branch information
@Robyer
Robyer committed Feb 16, 2016
1 parent cd7a176 commit 60cdede
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion live-form-validation.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ LiveForm.getMessageElement = function(el) {
LiveForm.getMessageParent = function(el) {
var parentEl = el.parentNode;

if (this.options.messageParentClass !== false {
if (this.options.messageParentClass !== false) {
while (!this.hasClass(parentEl, this.options.messageParentClass)) {
parentEl = parentEl.parentNode;

Expand Down

4 comments on commit 60cdede

@michalhisim
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tag this fix as 1.6.3 please. I should use in my bower.json older version or this commit hash.

@Robyer
Copy link
Contributor Author

@Robyer Robyer commented on 60cdede Feb 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, you're right.

Would be bad idea to re-tag it as 1.6.2 as the previous one is broken/not usable as a release anyway?

@Robyer
Copy link
Contributor Author

@Robyer Robyer commented on 60cdede Feb 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michalhisim For now I changed the v1.6.2 tag to the newer commit. Let me know if you think that could break something and I'll revert it and create new v1.6.3 eventually.

@michalhisim
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's much better. :)
For every new downloader is everything OK, but these people who have this version already installed and realizing problems nothing changed. I had to clear Bower cache to apply your change.

So it's up to you about new version. I don't know how much people is using your library.
Thank you!

Please sign in to comment.