Use OS default config dirs + minor fixes #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spiarh
force-pushed
the
spiarh_minor_fixes
branch
5 times, most recently
from
76df696 to
7c28525
Compare
prit342
approved these changes
Jan 5, 2024
spiarh
force-pushed
the
spiarh_minor_fixes
branch
from
c6f8116 to
a439406
Compare
There was a problem hiding this comment.
We need to discuss markdown auto formatting
- [//]: # (TODO document commands)
+ [//]: # "TODO document commands"
- |----------|-----------------------------------------------------------------------------------------------------------------|
+ | --------- | ---------------------------------------------------------------------------------------------------------------
prit342
force-pushed
the
spiarh_minor_fixes
branch
from
286d426 to
2af5209
Compare
feat: use XDG_CONFIG_HOME for linux style: improve readability feat: ensure bucket name is configured fix: ensure defer is always executed style: specify which variable we are looking for for aws region fix: set default log level to Info docs: remove for loop when building AMIs fix: use multi-arch image digests style: use same var name for amiBuilder in container/simulator cmd fix: remove unnecessary error wrapping fix: specify ansible config path explicitly with ANSIBLE_CONFIG refactor: use MkdirAll instead of Stat+Mkdir feat: add config print-dir flag for conveniency Signed-off-by: ludo <[email protected]>
Signed-off-by: ludo <[email protected]>
Signed-off-by: ludo <[email protected]>
spiarh
force-pushed
the
spiarh_minor_fixes
branch
from
2af5209 to
7b0258b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: