Fix/3779: Adjust logic for 'never' scope-enum validation

[joberstein]

Motivation and Context

Resolves issue #3779 - see for more context

Usage examples

/* commitlint.config.js */

// Commit message scopes, if present, must be one of the scopes in 'scope-enum'.
export default {
    rules: {
        "scope-enum": [2, "always", [
            "action",
            "test",
        ]]
    },
};

echo "feat(action): some message" | commitlint # passes
echo "feat(test): some message" | commitlint # passes
echo "feat(action, test): some message" | commitlint # passes
echo "feat(other, test): some message" | commitlint # fails
echo "feat(other): some message" | commitlint # fails

// Commit message scopes cannot include any of the scopes in 'scope-enum'.
export default {
    rules: {
        "scope-enum": [2, "never", [
            "action",
            "test",
        ]]
    },
};

echo "feat(action): some message" | commitlint # fails
echo "feat(test): some message" | commitlint # fails
echo "feat(action, test): some message" | commitlint # fails
echo "feat(other, test): some message" | commitlint # fails
echo "feat(other): some message" | commitlint # passes

How Has This Been Tested?

• Added more automated tests in addition to the ones that already exist (originally 18, now 36)
• Did manual testing with linked repo in separate test repo (npm i --no-save <path-to-dev-repo)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[joberstein]

This looks like a lot of changes, but in summary, I organized the old tests by use-case and they are still getting executed; in addition, I added more automated tests to cover all of the message types for the following cases for both always and never:

• Enum is empty (always passes for both always and never)
• Messages without scopes (always passes for both always and never)
• Always - messages with one or multiple scopes
• Never - messages with scopes

[escapedcat]

/cc @karl-run maybe can have a look as well

Thanks @joberstein ! Without people like you projects like commitlint couldn't continue.

[joberstein]

The value.length check was further down before; I can't reason out a case where "scopeEnum(..., 'never', [])" should fail, which was the original behavior, but just wanted to call this out.

[joberstein]

Main logic change, essentially from "!messageScopes.every(isScopeInEnum)"

[escapedcat]

Thanks @joberstein !