Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve console logs for skipping an updater with errors #918

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: improve console logs for skipping an updater with errors #918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/updaters/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
const chalk = require('chalk')
const path = require('path')
const JSON_BUMP_FILES = require('../../defaults').bumpFiles
const updatersByType = {
Expand Down Expand Up @@ -72,7 +73,11 @@ module.exports.resolveUpdaterObjectFromArgument = function (arg) {
updater.updater = getUpdaterByFilename(updater.filename)
}
} catch (err) {
if (err.code !== 'ENOENT') console.warn(`Unable to obtain updater for: ${JSON.stringify(arg)}\n - Error: ${err.message}\n - Skipping...`)
if (err.code !== 'ENOENT') {
console.warn(`${chalk.bgYellow.bold('[Warning]')} ${chalk.yellow(`Unable to obtain updater for: ${JSON.stringify(arg)}`)}`)
console.warn(`- ${chalk.red.bold('[Error]')}: ${err.message}`)
console.warn(`- ${chalk.red('Skipping updater...')}`);
}
}
/**
* We weren't able to resolve an updater for the argument.
Expand Down