[wip] second design for metrics operator #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is going to be a huge refactor to remove the application/storage "hard coded" legos replaced by a more flexible setup where we have one base metric set (no subtypes) and then metrics generate the replicated jobs (as many as they like, how they please) and then addons are provided to them, which can range from additional volumes to containers (that provide volumes) to any kind of customization. This is not ready for any kind of testing but I am mostly concerned about my computer blowing up and losing the work so I am saving for good measure :) Also, yay today! :D Signed-off-by: vsoch <[email protected]>
but might as well save the state of them! Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
we did not get this completely working before (likely the spack mpi install as a basic hostname does not work ) so a basic conversion is sufficient Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
vsoch
force-pushed
the
test-refactor-design
branch
from
7edaa43 to
92d93ff
Compare
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
also simplify logic of applications - the launcher worker pattern is generic and can be shared Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
it is accepted this does not fully work, we need to come back to it. Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
but shared libraries are failing to load. HPCToolkit you are a jerk. I am laughing. And crying. And mostly crying. Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
…file that is part of it! Signed-off-by: vsoch <[email protected]>
…run post commands Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
if we do not make a copy (refect) of the interface, the state seems to change (and perist) between runs. While I am still worried about this design, this at least seems to fix that bug. I am also wondering about garbage collection (e.g., if making the copies means they stay around and the operator will use increasing memory) but that is TBA explored. Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening a separate PR since I'm mucking with my environment / setup (and didn't want to bork it in case I messed up!) This is a continuation of #62. See there for verbose description.
Requirements before this can be merged:
And probably something else I didn't think of. I'm giving myself to the end of the week to complete this and prototype hpctoolkit as an addon with the lammps app. This probably could be enough work to spread out over a few weeks to a month... no pressure! But also, I think I'm going to try my damn best anyway.
Crap, commits aren't signed! Need to fix that, but going back to sleep for a bit :)