Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cxl-ui): [cxl-dialog] add dialog web component #216

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

anoblet
Copy link
Collaborator

@anoblet anoblet commented Aug 12, 2022

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 12, 2022

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js 58.63 KB (0%)

@lkraav
Copy link

lkraav commented Aug 12, 2022

Looks nice. Is there an update coming with the story?

@anoblet
Copy link
Collaborator Author

anoblet commented Aug 15, 2022

I've added a story.

I'm still working on getting events to function properly. vaadin-dialog relies heavily on document.body which is frustrating.

@anoblet
Copy link
Collaborator Author

anoblet commented Aug 19, 2022

I've been able to make some progress: https://deploy-preview-216--conversionxl-aybolit.netlify.app/?path=/story/cxl-ui-cxl-dialog--cxl-dialog

Edit: Updated link

@lkraav
Copy link

lkraav commented Aug 24, 2022

I've been able to make some progress: https://deploy-preview-216--conversionxl-aybolit.netlify.app/?path=/story/cxl-ui-cxl-dialog--vaadin

Deploy URL has become invalid, but I was able to click into the story from sidebar. Seems to work as expected.

Ideally this PR would also ship something that actually uses this new component, its purpose appears unclear otherwise.

@anoblet
Copy link
Collaborator Author

anoblet commented Aug 24, 2022

I plan on using it for this Clickup Task: https://app.clickup.com/t/2mmze19

I have a draft PR setup, that I need to update: #217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants