feat(cxl-ui): [cxl-vaadin-accordion] update mobile behavior #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
CU task? Totally unclear what this PR tries to do. |
|
@lkraav Added CU link and description. |
anoblet
force-pushed
the
anoblet/feat/cxl-vaadin-accordion
branch
3 times, most recently
from
b9bf94a
to
7b65bad
Compare
anoblet
force-pushed
the
anoblet/feat/cxl-vaadin-accordion
branch
from
7b65bad
to
2318f6d
Compare
|
OK this is way too much complicated code for what it's trying to accomplish 🤔 |
|
@lkraav What if we run the logic on first render rather than watching for device width changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.clickup.com/t/86773vpgj
When on mobile: