Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cxl-ui): [cxl-marketing-nav] navigation height #265

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat(cxl-ui): [cxl-marketing-nav] navigation height #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5fdd1d6
feat(cxl-ui): [cxl-marketing-nav] resize child menus if they are shor…
anoblet Feb 23, 2023
555ed34
feat(cxl-ui): [cxl-marketing-nav] improve navigation data
anoblet Feb 24, 2023
0ab4a84
feat(cxl-ui): [cxl-marketing-nav] only update menu height if on a wid…
anoblet Feb 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 24 additions & 12 deletions packages/cxl-ui/src/components/cxl-marketing-nav.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,21 +242,33 @@ export class CXLMarketingNavElement extends LitElement {
*
* @since 2023.02.11
*/
const overlays = document.querySelectorAll(
'vaadin-context-menu-overlay[theme="cxl-marketing-nav"]'
);

if (overlays.length > 1) {
const topLevelOverlay = overlays[0];
const listBox = overlay.querySelector('vaadin-context-menu-list-box');
const previousOverlay = overlays[overlays.length - 2];
const previousListBox = previousOverlay.querySelector('vaadin-context-menu-list-box');
// Check if we are on a wide screen.
if (this.wide) {
const overlays = document.querySelectorAll(
'vaadin-context-menu-overlay[theme="cxl-marketing-nav"]'
);

if (overlays.length > 1) {
const topLevelOverlay = overlays[0];
const listBox = overlay.querySelector('vaadin-context-menu-list-box');
const previousOverlay = overlays[overlays.length - 2];
const previousListBox = previousOverlay.querySelector('vaadin-context-menu-list-box');

// Reset list box height.
listBox.style.height = null;

requestAnimationFrame(() => {
// Check if the child list box is shorter then the parent list box.
if (listBox.offsetHeight < previousListBox.offsetHeight) {
// Set the child list box height to the parent list box height.
listBox.style.height = `${previousListBox.offsetHeight}px`;
}

requestAnimationFrame(() => {
if (listBox.offsetHeight > previousListBox.offsetHeight) {
// Align the child overlay to the top of the top level overlay.
overlay.style.top = topLevelOverlay.style.top;
}
});
});
}
}

/**
Expand Down
Loading