Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cxl-ui): [cxl-marketing-nav] add scroll indicator for large menus #277

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

anoblet
Copy link
Collaborator

@anoblet anoblet commented May 1, 2023

@anoblet anoblet requested a review from a team May 1, 2023 14:10
@github-actions
Copy link

github-actions bot commented May 1, 2023

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 33.73 KB (+0.44% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.87 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 24.9 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 125.6 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 197.26 KB (+0.08% 🔺)

Copy link

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anoblet it'd be useful to have screenshot here, so I created one:
Screenshot 2023-05-11 at 10 10 30

Proposed scroll indicator is too heavy. It should be something lightweight. Take a look at the horizontal cue we have for menus:

Screenshot 2023-05-11 at 10 10 11

White gradient background with an arrow would be better.

@anoblet anoblet requested a review from pawelkmpt May 12, 2023 14:21
@anoblet
Copy link
Collaborator Author

anoblet commented May 12, 2023

@pawelkmpt Updated

@pawelkmpt
Copy link

@pawelkmpt Updated

Looks better. Can we make it clickable like horizontal menu cues are?

Screenshot 2023-05-11 at 10 10 11

@anoblet
Copy link
Collaborator Author

anoblet commented May 17, 2023

@pawelkmpt Updated

@pawelkmpt
Copy link

I tested and when I get to the end of the list cue disappears in weird way making scrollbar smaller. It makes an impression of all elements jumping.

https://www.loom.com/share/bf9c27ac14e540e7b0d75bfb7aa3d80f

Can we do sth about it?

@lkraav
Copy link

lkraav commented May 30, 2023

Another "Should this even be done" discussion https://app.clickup.com/t/861mkj72q?comment=90040011549686

@anoblet
Copy link
Collaborator Author

anoblet commented Jun 1, 2023

@pawelkmpt I wasn't sure if it was more confusing to keep the scroll indicator once the user reached the bottom or not. I've updated this PR to keep the scroll indicator.

@anoblet anoblet requested review from a team and pawelkmpt and removed request for pawelkmpt June 1, 2023 13:40
@pawelkmpt
Copy link

@pawelkmpt I wasn't sure if it was more confusing to keep the scroll indicator once the user reached the bottom or not. I've updated this PR to keep the scroll indicator.

@anoblet I tested and it still has weird feeling because it's permanently visible there and clickable even if there's no more items at the and.

Ideally it should:

  • show bottom cue when there are items below the fold,
  • hide bottom cue when we get to the end of the list:
    • no jumping,
    • no padding,
  • show top cue when we start scrolling,
  • hide top cue when we get to the top of the list.

I'd try to achieve it with ::before ::after pieces and/or something absolutely positioned to avoid any padding/margin issues.

Is it doable with components setup we have?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants