Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cxl-lumo-styles): update cxl-lumo-styles and storybook #300

Merged
merged 3 commits into from
Nov 23, 2023

Conversation

freudFlintstone
Copy link

@freudFlintstone freudFlintstone self-assigned this Aug 3, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 66.93 KB (-0.08% 🔽)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.87 KB (+0.03% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 28.09 KB (+1.17% 🔺)
packages/cxl-ui/pkg/dist-web/vendor.js 135.58 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 243.63 KB (+0.12% 🔺)

@freudFlintstone freudFlintstone force-pushed the raphael/cxl-style-sync branch 3 times, most recently from 5fdb39b to ee150f3 Compare August 9, 2023 21:55
@freudFlintstone freudFlintstone marked this pull request as ready for review August 9, 2023 21:55
@freudFlintstone freudFlintstone requested review from lkraav, pawelkmpt and anoblet and removed request for lkraav, pawelkmpt and anoblet August 9, 2023 21:55
@freudFlintstone freudFlintstone marked this pull request as draft August 11, 2023 14:07
@freudFlintstone freudFlintstone force-pushed the raphael/cxl-style-sync branch 2 times, most recently from 6eccd6a to 05eea70 Compare September 7, 2023 14:32
@freudFlintstone freudFlintstone marked this pull request as ready for review September 7, 2023 18:38
@freudFlintstone freudFlintstone marked this pull request as draft September 13, 2023 22:17
@freudFlintstone freudFlintstone force-pushed the raphael/cxl-style-sync branch 5 times, most recently from 5c307b8 to 24ead3f Compare September 29, 2023 01:40
@freudFlintstone freudFlintstone force-pushed the raphael/cxl-style-sync branch 2 times, most recently from da61875 to 1d2ca02 Compare October 2, 2023 13:08
Copy link

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@freudFlintstone quick glance review on this draft code. I'll go deeper once PR is ready for review

packages/cxl-lumo-styles/scss/_mixins.scss Outdated Show resolved Hide resolved
packages/cxl-lumo-styles/scss/_mixins.scss Outdated Show resolved Hide resolved
packages/cxl-lumo-styles/scss/_mixins.scss Outdated Show resolved Hide resolved
packages/cxl-lumo-styles/scss/_mixins.scss Outdated Show resolved Hide resolved
packages/cxl-lumo-styles/scss/_mixins.scss Outdated Show resolved Hide resolved
packages/cxl-lumo-styles/scss/themes/vaadin-button.scss Outdated Show resolved Hide resolved
packages/storybook/cxl-lumo-styles/typography.stories.js Outdated Show resolved Hide resolved
packages/storybook/cxl-lumo-styles/typography.stories.js Outdated Show resolved Hide resolved
packages/cxl-lumo-styles/scss/_mixins.scss Outdated Show resolved Hide resolved
packages/cxl-ui/scss/cxl-dashboard-header.scss Outdated Show resolved Hide resolved
@freudFlintstone freudFlintstone marked this pull request as ready for review October 3, 2023 18:18
.gitignore Outdated Show resolved Hide resolved
@freudFlintstone freudFlintstone force-pushed the raphael/cxl-style-sync branch 2 times, most recently from 5740e05 to 79817e6 Compare November 1, 2023 16:36
@freudFlintstone freudFlintstone changed the title refactor(cxl-lumo-styles): update storybook with current home page styles refactor(cxl-lumo-styles): update cxl-lumo-styles and storybook Nov 1, 2023
@freudFlintstone
Copy link
Author

Task linked: CU-861n2cqe7 CXL Style sync

@freudFlintstone freudFlintstone changed the title refactor(cxl-lumo-styles): update cxl-lumo-styles and storybook refactor(cxl-lumo-styles): update cxl-lumo-styles and storybook CU-861n2cqe7 Nov 2, 2023
@freudFlintstone freudFlintstone force-pushed the raphael/cxl-style-sync branch 2 times, most recently from fd215c1 to 7706b55 Compare November 8, 2023 12:28
@freudFlintstone freudFlintstone changed the title refactor(cxl-lumo-styles): update cxl-lumo-styles and storybook CU-861n2cqe7 refactor(cxl-lumo-styles): update cxl-lumo-styles and storybook Nov 21, 2023
Copy link

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@freudFlintstone yarn build fails. As you can see, GH couldn't do it either.

Screenshot 2023-11-22 at 11 15 34

@pawelkmpt pawelkmpt merged commit 210d3ae into master Nov 23, 2023
5 checks passed
@pawelkmpt pawelkmpt deleted the raphael/cxl-style-sync branch January 9, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants