Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cxl-ui): refactor cxl-dashboard-header #349

Closed
wants to merge 1 commit into from

Conversation

HenerHoop
Copy link

@HenerHoop HenerHoop commented Oct 25, 2023

https://app.clickup.com/t/86ayhhfgy

Slider is currently using the old card until the light-card update gets merged.

@github-actions
Copy link

github-actions bot commented Oct 25, 2023

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 62.96 KB (-1.09% 🔽)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.87 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 27.72 KB (+0.21% 🔺)
packages/cxl-ui/pkg/dist-web/vendor.js 135.58 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 239.28 KB (-0.27% 🔽)

@HenerHoop HenerHoop force-pushed the hener/feat/refactor-my-dashboard branch 2 times, most recently from e7f3b30 to afab151 Compare October 26, 2023 07:25
@HenerHoop HenerHoop marked this pull request as ready for review October 26, 2023 07:29
@HenerHoop HenerHoop force-pushed the hener/feat/refactor-my-dashboard branch from afab151 to 3f79af8 Compare October 26, 2023 13:33
@HenerHoop HenerHoop force-pushed the hener/feat/refactor-my-dashboard branch from 3f79af8 to 36cdb51 Compare October 26, 2023 14:35
Copy link

@freudFlintstone freudFlintstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@HenerHoop
Copy link
Author

@pawelkmpt I think that this PR is no longer valid because the roadmap block's PR already includes it (with small changes). It was necessary to add it there to see the entire header together.

@pawelkmpt pawelkmpt closed this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants