refactor(cxl-ui): use @lit/context for media queries #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
anoblet
force-pushed
the
anoblet/refactor/context
branch
2 times, most recently
from
83044fe
to
d964bfb
Compare
|
Task linked: CU-86aymme98 Explore @lit/context |
anoblet
force-pushed
the
anoblet/refactor/context
branch
from
d964bfb
to
feb9cac
Compare
lkraav
reviewed
Jan 10, 2024
| @@ -0,0 +1,3 @@ | |||
| import { createContext } from '@lit/context'; | |||
|
|
|||
| export const mediaContext = createContext(Symbol('media-context')); | |||
There was a problem hiding this comment.
Should it be a more specific mediaQueryContext maybe?
"Media" alone seems like could be related to video, or whatnot more broad concept.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.