Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cxl-ui): implement dashboard facelift #367

Merged
merged 1 commit into from
Dec 18, 2023
Merged

refactor(cxl-ui): implement dashboard facelift #367

merged 1 commit into from
Dec 18, 2023

Conversation

freudFlintstone
Copy link

@freudFlintstone freudFlintstone self-assigned this Nov 28, 2023
@freudFlintstone
Copy link
Author

Task linked: CU-86ayt69ga Dashboard facelift

@freudFlintstone freudFlintstone changed the title Raphael/refactor/dashboard/facelift refactor(cxl-ui): implement dashboard facelift Nov 28, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2023 •
edited
Loading

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 69.66 KB (+0.19% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.89 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 28.83 KB (+0.12% 🔺)
packages/cxl-ui/pkg/dist-web/vendor.js 140.5 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 252.03 KB (+0.07% 🔺)

@freudFlintstone freudFlintstone force-pushed the raphael/refactor/dashboard/facelift branch 3 times, most recently from 3e22fa8 to 34154fb Compare November 30, 2023 12:34
@pawelkmpt
Copy link

@freudFlintstone please rebase and solve conflicts

@freudFlintstone freudFlintstone force-pushed the raphael/refactor/dashboard/facelift branch 4 times, most recently from 9c9ba9f to a3436ee Compare December 11, 2023 22:15
pawelkmpt
pawelkmpt requested changes Dec 18, 2023
View reviewed changes
Copy link

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@freudFlintstone mobile is broken...

Also please rebase on top of master

Screenshot 2023-12-18 at 12 14 22
Screenshot 2023-12-18 at 12 14 32
Screenshot 2023-12-18 at 12 14 47

@heshfekry
Copy link

@freudFlintstone put it back to original width not half-width then. removes the problem?

@pawelkmpt
Copy link

Please also make stat font consistent

Screenshot 2023-12-18 at 13 17 47

@pawelkmpt
Copy link

And one more thing in featured slider, image corner is visible "above" rounded corner. It should be hidden "behind".

https://www.loom.com/share/dce82d61ade041569094ef01d3a113fa?sid=7e8d288a-800a-450a-9155-32071e1f7bb1

@freudFlintstone freudFlintstone force-pushed the raphael/refactor/dashboard/facelift branch from a3436ee to d4c0f9d Compare December 18, 2023 15:09
@freudFlintstone
Copy link
Author

And one more thing in featured slider, image corner is visible "above" rounded corner. It should be hidden "behind".

https://www.loom.com/share/dce82d61ade041569094ef01d3a113fa?sid=7e8d288a-800a-450a-9155-32071e1f7bb1

@pawel I had seen that already. The problem is how the browser renders those transitions. I don't have a solution yet.
The obvious fix (giving the same border with overflow: hidden to the outermost parent, doesn't work). I'm going to do some research on this.

pawelkmpt
pawelkmpt requested changes Dec 18, 2023
View reviewed changes
Copy link

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right padding needed for blue sections

Screenshot 2023-12-18 at 16 26 27
Screenshot 2023-12-18 at 16 26 46

@freudFlintstone freudFlintstone force-pushed the raphael/refactor/dashboard/facelift branch from d4c0f9d to 9d8d983 Compare December 18, 2023 15:39
@pawelkmpt pawelkmpt merged commit 7dd7160 into master Dec 18, 2023
5 checks passed
@pawelkmpt pawelkmpt deleted the raphael/refactor/dashboard/facelift branch December 18, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelkmpt pawelkmpt pawelkmpt approved these changes

@lkraav lkraav Awaiting requested review from lkraav

@anoblet anoblet Awaiting requested review from anoblet

Assignees

@freudFlintstone freudFlintstone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@freudFlintstone @pawelkmpt @heshfekry