feat(cxl-ui): cxl-card-grid component, light and course card examples #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
Task linked: CU-86ayk4p69 Completed course section |
pawelkmpt
reviewed
Dec 13, 2023
freudFlintstone
suggested changes
Dec 13, 2023
Comment on lines
7
to
10
| ::slotted(.grid) { | ||
| display: grid; | ||
| grid-template-columns: repeat(1, 1fr); | ||
| gap: var(--lumo-space-m); |
There was a problem hiding this comment.
Why the need to slot in a .grid element? If we style the host itself to be the grid container, we achieve the same result and allow parent elements to adapt the style if needed. That's important in our setup, to be able to easily re-use the element in wp and make changes by applying desired classes. Just slot the cards directly.
Comment on lines
1
to
7
| cxl-card-grid { | ||
| cxl-light-card, | ||
| cxl-course-card { | ||
| width: 100%; | ||
| max-width: none; | ||
| } | ||
| } |
There was a problem hiding this comment.
Same problem. By styling the component :host directly, we avoid unnecessary complexity with global stylesheets. We should only use global styles when there's no other way.
freudFlintstone
approved these changes
Dec 14, 2023
pawelkmpt
reviewed
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.clickup.com/t/86ayk4p69
To add a title (for e, wrap it inside the card-grid section and insert the title
To use as a section with a title, wrap cxl-card-grid inside the cxl-section. Example:
<cxl-section> <h3 style="margin: var(--lumo-space-xl) 0">Completed Courses</h3> <cxl-card-grid></cxl-card-grid> </cxl-section>