Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cxl-ui): cxl-dashboard-header -> remove unnecessary padding #374

Merged
merged 1 commit into from
Dec 19, 2023
Merged

fix(cxl-ui): cxl-dashboard-header -> remove unnecessary padding #374

merged 1 commit into from
Dec 19, 2023

Conversation

freudFlintstone
Copy link

@freudFlintstone freudFlintstone self-assigned this Dec 18, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2023 •
edited
Loading

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 69.66 KB (+0.01% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.89 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 28.83 KB (+0.02% 🔺)
packages/cxl-ui/pkg/dist-web/vendor.js 140.5 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 252.04 KB (+0.01% 🔺)

pawelkmpt
pawelkmpt requested changes Dec 18, 2023
View reviewed changes
Copy link

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side effect: top margin gone

Screenshot 2023-12-18 at 18 05 44

@pawelkmpt pawelkmpt merged commit 4d828c9 into master Dec 19, 2023
5 checks passed
@pawelkmpt pawelkmpt deleted the raphael/fix/dashboard/layout branch December 19, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelkmpt pawelkmpt pawelkmpt approved these changes

@lkraav lkraav Awaiting requested review from lkraav

@anoblet anoblet Awaiting requested review from anoblet

Assignees

@freudFlintstone freudFlintstone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@freudFlintstone @pawelkmpt