-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cxl-ui): fix mobile layout issues in course pages #377
Conversation
size-limit report 📦
|
7c95394
to
b5a9f38
Compare
Task linked: CU-86aykudx5 Deployment of new component |
This looks good! It seems you have a better idea of the issue and could have it solved quicker. Should we revert this commit? 73a306b |
@anoblet I definitely wish I had understood the issue faster. But this is not a proper fix, it's just a workaround, since we still don't know what's causing the overflow. Do not revert the other commit. It fixes a real issue that would have the same effect. The reason I thought it was the only cause is that it fixed it in local development. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should fix the menu gap issue. Adding overflow hidden to cxl-app-layout works using inspector on live. There's also a chance it could fix some of the animation issues we face when opening the menu for the first time.
b5a9f38
to
55de700
Compare
@anoblet I tested the code on live, fixed one issue @freudFlintstone introduced (missing card styles due the removal of I also deleted b5a9f38 with This code is live on blog and institute. |
This seems to fix https://cxl.com/webinars. On Institute pages we still have a horizontal scroll which I can't seem to find in inspector. |
No description provided.