Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificate header: credential fit #384

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Conversation

pawelkmpt
Copy link

Result after changes

Screenshot 2024-01-11 at 11 44 03
Screenshot 2024-01-11 at 11 44 18
Screenshot 2024-01-11 at 11 44 51
Screenshot 2024-01-11 at 11 45 11
Screenshot 2024-01-11 at 11 46 22
Screenshot 2024-01-11 at 11 46 35

@pawelkmpt pawelkmpt self-assigned this Jan 11, 2024
Copy link

github-actions bot commented Jan 11, 2024

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 71.7 KB (+0.76% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.89 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 28.84 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 140.5 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 254.08 KB (+0.22% 🔺)

@pawelkmpt
Copy link
Author

Task linked: CU-86ayg4prn Course complete page

@heshfekry
Copy link

@pawelkmpt

Certificate looks fine.

Unrelated to this but since its here too.

  • Course title > H1
  • Course completed > h2
  • I noticed the same on MD 2,0 pages too. Title is a large lato instead of an H1.

@pawelkmpt
Copy link
Author

Certificate looks fine.

Unrelated to this but since its here too.

  • Course title > H1
  • Course completed > h2
  • I noticed the same on MD 2,0 pages too. Title is a large lato instead of an H1.

@heshfekry better?

Screenshot 2024-01-11 at 14 28 31

New property if set `true`, sets credential width to the width of
credential parent element (wrapper).

This makes component size correct on different screen sizes.
…ments

Adjust width of the content and credential depending on the screen size.
@lkraav
Copy link

lkraav commented Jan 12, 2024

Sports psychology talks about avoiding negatives, like Don't stop, which puts the word Stop in athlete mind.

Better: «Keep going!»

@pawelkmpt pawelkmpt merged commit d84380f into master Jan 12, 2024
5 checks passed
@pawelkmpt pawelkmpt deleted the pawel/feat/credential-fit branch January 12, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants