Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cxl-lumo-styles): typography Raleway -> Montserrat #386

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

pawelkmpt
Copy link

No description provided.

@pawelkmpt pawelkmpt self-assigned this Jan 12, 2024
Copy link

github-actions bot commented Jan 12, 2024

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 71.73 KB (+0.06% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.89 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 28.84 KB (+0.03% 🔺)
packages/cxl-ui/pkg/dist-web/vendor.js 140.5 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 254.12 KB (+0.02% 🔺)

@pawelkmpt
Copy link
Author

H3

I suggest to either:

  • change h3 weight to 700 globally
  • or change weight on course cards.

Please look at the screenshots attached. One of the cards has title with 700 instead of 900.

Screenshot 2024-01-12 at 11 31 16
Screenshot 2024-01-12 at 11 31 37

@heshfekry
Copy link

heshfekry commented Jan 12, 2024

Course Cards should have same weight. Lets go with 700 as its saner to maintain.

If its trivial I would even switch this to Lato.

@pawelkmpt
Copy link
Author

Course Cards should have same weight. Lets go with 700 as its saner to maintain.

I was not clear enough. I made one of them 700 to show the difference in look. By default all are 900.

If its trivial I would even switch this to Lato.

OK, I will adjust.

@pawelkmpt
Copy link
Author

@heshfekry done

Screenshot 2024-01-12 at 12 36 05
Screenshot 2024-01-12 at 12 36 10

what about featured courses? which version do you like more?
Screenshot 2024-01-12 at 12 35 46

@heshfekry
Copy link

featured courses - Use montserrat.

@heshfekry
Copy link

For the rest seems fine @pawelkmpt

@pawelkmpt pawelkmpt force-pushed the pawel/feat/typography-montserrat branch from a840189 to 547c6a7 Compare January 12, 2024 12:27
@pawelkmpt pawelkmpt force-pushed the pawel/feat/typography-montserrat branch from 547c6a7 to d8f616b Compare January 12, 2024 13:15
@pawelkmpt pawelkmpt merged commit d9d2309 into master Jan 12, 2024
5 checks passed
@pawelkmpt pawelkmpt deleted the pawel/feat/typography-montserrat branch January 12, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants