Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update styles #388

Merged
merged 5 commits into from
Jan 23, 2024
Merged

Update styles #388

merged 5 commits into from
Jan 23, 2024

Conversation

anoblet
Copy link
Collaborator

@anoblet anoblet commented Jan 16, 2024

Copy link

github-actions bot commented Jan 16, 2024

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 71.88 KB (+0.12% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.89 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 28.93 KB (+0.17% 🔺)
packages/cxl-ui/pkg/dist-web/vendor.js 140.5 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 254.35 KB (+0.06% 🔺)

@anoblet anoblet marked this pull request as ready for review January 22, 2024 14:25
Copy link

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anoblet I see lot of formatting changes. When @freudFlintstone submitted code there was also lots of them. Are we all running the same code formatter or everyone their own? How I can be sure it's working in my environment?

@pawelkmpt pawelkmpt merged commit 0ba2738 into master Jan 23, 2024
5 checks passed
@pawelkmpt pawelkmpt deleted the anoblet/feat/style branch January 23, 2024 11:45
@anoblet
Copy link
Collaborator Author

anoblet commented Jan 23, 2024

@anoblet I see lot of formatting changes. When @freudFlintstone submitted code there was also lots of them. Are we all running the same code formatter or everyone their own? How I can be sure it's working in my environment?

@pawelkmpt stylelint and prettier should run before every commit. I'm not sure why these formatting changes weren't applied corrected before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants