refactor(cxl-ui): cxl-course-card, dashboard #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
anoblet
approved these changes
Jan 25, 2024
|
We might be able to use |
|
Since the height of the pill is larger than the tags, I would suggest vertically aligning everything. |
* remove new (star) icon * make tag more prominent, styled as one from cxl-light-card https://app.clickup.com/t/86az50h3y?comment=90140017966111
Make it a real section component for dashboard, keep consitent paddings and avoid inline code defining it.
pawelkmpt
force-pushed
the
pawel/feat/course-card-new
branch
from
a71c060
to
1a8acef
Compare
Done @anoblet :) |
pawelkmpt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.clickup.com/t/86az50h3y?comment=90140017966111
BEFORE
AFTER
