Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cxl-ui): update hero font sizes #408

Merged
merged 2 commits into from
May 6, 2024
Merged

feat(cxl-ui): update hero font sizes #408

merged 2 commits into from
May 6, 2024

Conversation

anoblet
Copy link
Collaborator

@anoblet anoblet commented Apr 26, 2024

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 26, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 74.5 KB (+0.12% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.89 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 30.98 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 140.5 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 259.02 KB (+0.04% 🔺)

pawelkmpt
pawelkmpt requested changes Apr 26, 2024
View reviewed changes
Copy link

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anoblet please remember to use component name in the commit message

- feat(cxl-ui): update hero font sizes
+ feat(cxl-ui): cxl-section update hero font sizes

@anoblet anoblet force-pushed the anoblet/feat/hero branch 3 times, most recently from 83b5e54 to b817776 Compare April 26, 2024 16:43
@anoblet anoblet requested a review from pawelkmpt April 30, 2024 14:49
@pawelkmpt
Copy link

Works well now

@pawelkmpt pawelkmpt merged commit 8972f17 into master May 6, 2024
5 checks passed
@pawelkmpt pawelkmpt deleted the anoblet/feat/hero branch May 6, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelkmpt pawelkmpt pawelkmpt approved these changes

@lkraav lkraav Awaiting requested review from lkraav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anoblet @pawelkmpt