Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cxl-ui): cxl-intercom #419

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

pawelkmpt
Copy link

I took pieces of code from https://github.com/calibreapp/react-live-chat-loader and created custom component. Basic test shown it works but detailed feedback is welcome

https://app.clickup.com/t/1vhwc7g?comment=90140045352236

@pawelkmpt pawelkmpt requested review from lkraav and anoblet June 27, 2024 14:11
@pawelkmpt pawelkmpt self-assigned this Jun 27, 2024
Copy link

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 46.39 KB (+4.96% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.89 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 28.99 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 138.31 KB (+0.06% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-institute.js, packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 278.07 KB (+0.83% 🔺)

@anoblet anoblet self-requested a review June 28, 2024 15:07
Copy link

@lkraav lkraav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, excited to see if this works as expected.

How does it operate on push messages?

packages/cxl-ui/scss/cxl-intercom.scss Show resolved Hide resolved
load() {
const loaded = this.loadScript();

// Continue as long as userlike hasn’t already been initialised.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's a "userlike"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants