Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cxl-ui): cxl-marketing-nav remove max width from the navigation bar #424

Closed
wants to merge 1 commit into from

Conversation

anoblet
Copy link
Collaborator

@anoblet anoblet commented Jul 16, 2024

@anoblet anoblet requested review from lkraav and pawelkmpt July 16, 2024 13:54
Copy link

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 44.19 KB (-0.03% 🔽)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.89 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 28.99 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 138.23 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-institute.js, packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 275.79 KB (-0.01% 🔽)

Copy link

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing max-width pushes everything to the left everywhere. I think it was not an intention.

Screenshot 2024-07-19 at 11 19 45

@anoblet
Copy link
Collaborator Author

anoblet commented Jul 23, 2024

I think we can close this. The original page looks like it's been edited to not use cxl-marketing-nav. (https://cxl.com/institute/online-course/bottom-of-funnel-seo-strategies-in-tough-niches/)

@anoblet anoblet closed this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants