Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shared Stops Validation #395

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Shared Stops Validation #395

merged 1 commit into from
Aug 25, 2023

Conversation

miles-grant-ibigroup
Copy link
Collaborator

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

This PR adds a really hacky public access modifier to allow datatools server to do a database access within its validator

philip-cline
philip-cline approved these changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@philip-cline philip-cline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got me on record signing off on this, perfect

@miles-grant-ibigroup miles-grant-ibigroup merged commit c348533 into dev Aug 25, 2023
2 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the shared-stops-validation branch August 25, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

@philip-cline philip-cline philip-cline approved these changes

Assignees

@miles-grant-ibigroup miles-grant-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miles-grant-ibigroup @binh-dam-ibigroup @philip-cline