fix segfaults in docker containers built for the wrong architecture #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On certain architectures, when Crypt::Argon2 is built for `-march=native` but then run on a different architecture (which is easy to do when building on say github actions then deploying elsewhere) the resulting build of the library will segfault when convos attempts to login, killing the container. Since Crypt::Argon2 version 0.22 an environment variable is available that allows building without the `-march=native` optimization (when set to NONE).
jberger
force-pushed
the
fix-argon2-build
branch
from
c133c9f to
018a930
Compare
|
Please open a PR to https://github.com/convos-chat/docker-base instead, and just merge it. Sorry for not being more responsive, but things are a bit crazy these days 🙈 After the base image is built, I can make a new release. Or you can do it yourself:
The problem with adding it here is that I don't know if it will get built, since it might already be built in docker-base. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On certain architectures, when Crypt::Argon2 is built for
-march=nativebut then run on a different architecture (which is easy to do when building on say github actions then deploying elsewhere) the resulting build of the library will segfault when convos attempts to login, killing the container.Since Crypt::Argon2 version 0.22 an environment variable is available that allows building without the
-march=nativeoptimization (when set to NONE).Fixes #885