This repository has been archived by the owner on Dec 7, 2024. It is now read-only.
Metabase workflow testing #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put in capability but not link it in for nested column enrichment for postgres JSON columns
* Create action for Uberjar * Fixing name * Adding shell bash to SHA * Adding shell on proper place * Adding one more shell
* Upgrade Cypress to the latest version (9.4.1) * Fix collections tests failures after upgrade * Fix binning tests failures after upgrade * Fix dashboard test failures after upgrade * Fix models test failures after upgrade * Fix admin test failures after upgrade * Fix visualizations test failures after upgrade * Rewrite and fix repro for 17397 Added the missing issue reference. * Fix question test failures after upgrade * Fix interception handlers in metabase-visual tests * Fix the rest of the binning tests after upgrade * rewrite cypressWaitAll helper with a simple recursion * Updating to 9.5.0 * Upgrade Cypress to v9.5.1 * Fix repro for 13332 * Fix pinned items `collections` test failures * Speed `collection-pinned-overview` spec up using the API * Fix failing localization test Co-authored-by: Aleksandr Lesnenko <[email protected]> Co-authored-by: Diogo Mendes <[email protected]>
…etabase#20921) * Add the :archived status of card/dashboard/collection for filtering If an item is bookmarked, we can follow the link to that item without issue. But, if we bookmark an item and then archive that item, the bookmark shouldn't show up, as we don't want to link to an archived item. The bookmark itself is not removed, it's just filtered away when :archived is true. * Added test for bookmarked and archived items The archived items that are still bookmarked should not be sent to the Frontend.
* Update env vars of SAML Adding some very important comments * Update docs/operations-guide/environment-variables.md Co-authored-by: flamber <[email protected]> Co-authored-by: flamber <[email protected]>
* Fix ssl-key connection prop name * Adds unit test for ssl-key typo fix * fix ns require ordering Co-authored-by: Guillermo Ríos <[email protected]>
* Localize personal colections's name * adding a macro to generate test data * use precondition instead of assert * fix per comment
* Creating cypress action * Adding shell
* use site-url when opening links via JS * fix normalization of 0 value * make dashboard click drill to same dashboard just update parameters * fix race condition with location prop * use Link instead of anchor tag
…ms (metabase#20907) * Improved error messages when query execution fails * Pretty-print hx/identifier in a different way if it contains extra keys * Fix metabase#20806 * Rename key used to record that we should not qualify * Fix line breaks * Test fix 🔧
* Match the z-index of old popovers * Add flip prop to TippyPopover
This way, if the field name contains [ or ], this character will be handled properly (with escaping and unescaping at the right place). Ensure escape vs unescape symmetry
- sorting in query so don't have to sort in memory afterwards, and leaves open spot on the api to sort with user preferences if present (future work) - adds schema so we know what these bookmarks look like, and return an explicit structure instead of threading through dissoc and assoc - combined the remove-nil-values into the normalize function since it set up preconditions necessary for the normalize. - use Models in query so we don't have to hardcode the underlying table
* TimeSeriesLineChart uses scaleBand instead of scaleTime for x-axis Similar to TimeSeriesBarChart * TimeSeriesAreaChart updated to match TimeSeriesLineChart
…#21280) * Revert "Log database connection error before humanizing it (metabase#10695)" This reverts commit 426df16. This is no longer needed. The original exception message is kept in the inner exception and everywhere this is used, the whole stack trace is logged anyway. * Don't log exception when opportunistically trying SSL
New releases of maildev were recently made which has UI changes as well as changing the default port from 25 to 1025, causing tests to fail. While we may want to upgrade maildev in the future, let's stick to the old version first to unbreak all the tests.
All under the grand path to metabase#708. Changes field API to be compatible with nfc-paths. Allows joining of nested field columns by shoving the full identifier into the postgres function call. Also fixes arcane macro test bug by not using the macro.
* fix minute index * test specific timeseries intervals
metabase#21346) * Test 8vCPU * Run just uberjar for metrics * Testing with 8 * Reverting commented code
…se#21171) * Added bookmarked-score to enable boosting of bookmarked items * Collection Search Query doesn't error with bookmark left join * adjust collection id AS in base query * Set proper bookmark status in collection for search tests * Actually score bookmarks when bookmarked * Added a bookmark scoring test * Remove old todo since it does work. (yay)
* Rebase * Adding maildev version copying Pawit's commit on this specific file
* Remove errant :bookmarked hydration key This was left over from an incorrect implementation of :bookmarked status. No :bookmarked hydration function exists anyway, the key does nothing. * Remove old favorites models that are superceded by bookmarks * Remove dashboard favorite require
* Downgrade download action version * Revert upload action
* Prototype new nav skeleton (metabase#20875) * yarn * begin basic layout flip * rough in collections list * position query builder * remove fitViewport from QB to fix layout quirks * extract search * clean up props * position search / style * fix dashboard layout * fix search icon * move ProfileLink * tweak spacing * fix burger * add basic toggle * tweak layout for sidebar toggle * tweak style * tweak sidebar sizing * Quick fix to prototype starting points init (metabase#20922) * fix scroll overflow on sidebar Co-authored-by: Gustavo Saiani <[email protected]> * add currentUser to profile link * move footer items out of collection sidebar * tweak footer style * fix hover style * clean up footer * fixup * remove un-needed overflow hidden * hide app bar when in admin mode * merge sidebar header into new color scheme / nav layout * clean up headers * fix root collection spacing * smaller font size for nav items * provide flex context, fixes metadata editing * fix login page * Remove console logs * Put user's personal collection under Our analytics (metabase#21061) * Browsing | Handle long item names in the sidebar (metabase#21063) * Handle long names in the nav sidebar * Show tooltip with a full item name if its cut * Browsing | Fix data reference & admin permissions layout (metabase#21101) * Remove admin navbar CSS fix * Handle admin navbar in root App component * Extract styled components * Fix data reference layout * Fix main container height * Browsing | Hide sidebar for questions, models and dashboards on page open (metabase#21064) * Manage default sidebar visibility * Handle ad-hoc questions better * Move nav elements based on feedback (metabase#21190) * scoot buttons around * move logo to appbar, scoot search * remove user footer, home link [ci skip] * review feedback [ci skip] * fix accidental removal of links (minimalism was a fad anyway) (metabase#21192) * add button classes to new button (metabase#21213) * Nav visual changes (metabase#21223) * switch nav bg + move styling to NavRoot * readable text * increase contrast * selected icon color * remove bottom padding * search bar color * restructure sidebar position * fix sidebar header color * move to fixed when small * fix multiple scrollbars * fix sidebar width * home as own item, gear below * fix admin nav * extract nav constant, fix types * remove unused constant [ci skip] * New nav - get base colors in order (metabase#21262) * new sidebar button * nav bg to bg-light * fix link track, remove extra home link * color tweaks * swap colors * Fix E2E tests for new navigation UI (metabase#21196) * Use `main` HTML tag for main page content * Add extra UI helpers for Cypress * Fix tests failing due to nav UI changes * Remove not needed NavBar code * Fix loading databases list * Use `navigationSidebar` helper for collections * Use `navigationSidebar` for collection tests * Close sidebar in SQL filters tests * Extract AppBar component to `metabase/nav` * Fix test * Fix test * Skip sidebar visibility control test * Fix JSON engine DB check * Fix DatasetEditor edit bar colors * Fix global containers heights * Fix tests scrolling target * Fix styles * Fix navbar cypress helpers * [ci nocache] * Fix scroll in e2e test * Browsing | Manage sidebar state with redux (metabase#21226) * Move navbar state to redux * Hide sidbebar using CSS * Fix native E2E test * Fix native e2e test * Fix model tests * Use more accurate element getters * Fix e2e tests * Browsing | Fix dashboard UI (metabase#21233) * Fix parameter widgets event listeners * Attach scroll events to "main" instead of window * Resize filters panel when navigation sidebar open * Reorder imports at App * Hide AppBar and NavBar when editing dashboard * Fix navbar & appbar visibility * Fix filter positions * Extract `getMainElement` helper * Update unit tests * Fix test * Browse fix bulk actions (metabase#21320) * make bulk action bar aware of sidebar, remove extraneous layout components * clean up styling * convert BulkActionBar to tsx * Fix types Co-authored-by: Kyle Doherty <[email protected]> Co-authored-by: Gustavo Saiani <[email protected]> Co-authored-by: Aleksandr Lesnenko <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metabase workflow testing