Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #35

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Refactor #35

wants to merge 4 commits into from

Conversation

arifaydogmus
Copy link

@arifaydogmus arifaydogmus commented Jun 28, 2020 •
edited
Loading

  • Bottender upgraded.
  • Slash command support added. ( This requires to add slash commands (balance, deposit, withdraw) to bot on Slack console)

Refactoring

  • sendDoge fn created to unify sending actions.
  • command removed and simplified in src/index
  • errors send to user as a ephemeral message. (visible only to user)
  • Bot reacts to original channel message with cool doge gif after successful transaction
  • Sends DM to user whom received some doge
  • Multiple recipients support added to tip

Arif Aydogmus added 2 commits June 28, 2020 06:09
upgrade bottender
7ecd373 
refactor
add slash commands
update readme
3c0ef40
a-w-e-s-o-m-e
a-w-e-s-o-m-e requested changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@a-w-e-s-o-m-e a-w-e-s-o-m-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing stuff! The new changes work although I think there is the need of a bit of tweak. I left some comments in this review.

🤖 👏 @arifaydogmus

.eslintignore Outdated Show resolved Hide resolved
jest.config.js Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
src/lib/sendDoge.ts Outdated Show resolved Hide resolved
src/lib/sendDoge.ts Outdated Show resolved Hide resolved
bottender.config.js Show resolved Hide resolved
README.md Show resolved Hide resolved
@a-w-e-s-o-m-e a-w-e-s-o-m-e mentioned this pull request Jul 1, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-w-e-s-o-m-e a-w-e-s-o-m-e a-w-e-s-o-m-e requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arifaydogmus @a-w-e-s-o-m-e