Fix code scanning alert no. 470: Multiplication result converted to larger type #128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/cooljeanius/apple-gdb-1824/security/code-scanning/470
To fix the problem, we need to ensure that the multiplication is performed using a larger integer type to prevent overflow. We can cast one of the operands to
size_t
before performing the multiplication. This will ensure that the multiplication is done using the larger type, thus avoiding overflow.The specific changes required are:
max_y
tosize_t
before multiplying it withmax_x
in thememset
function calls.max_y
tosize_t
before multiplying it withmax_x
in thegdb_malloc
function calls.Suggested fixes powered by Copilot Autofix. Review carefully before merging.