Fix code scanning alert no. 683: Suspicious add with sizeof #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/cooljeanius/apple-gdb-1824/security/code-scanning/683
To fix the problem, we need to ensure that the pointer arithmetic is done correctly. Instead of adding
sizeof(ext_ldmbuf_partial)to the pointer, we should add the number of elements. This can be achieved by casting the pointer to agdb_byte *type before performing the arithmetic. This way, the arithmetic will be done in terms of bytes, which is the intended behavior.gdb_byte *before adding the offset.Suggested fixes powered by Copilot Autofix. Review carefully before merging.