Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate GitHub workflows on Ubuntu and macOS. #56

Closed
wants to merge 1 commit into from
Closed

Generate GitHub workflows on Ubuntu and macOS. #56

wants to merge 1 commit into from

Conversation

Zimmi48
Copy link
Member

@Zimmi48 Zimmi48 commented Aug 11, 2021

@siraben Here is a quick and dirty alternative to #53 (to close #48). The relevant changes are those in .nix/shellHook.sh.

I say quick and dirty because we may want to make the list of platforms to run CI on configurable in .nix/config.nix and we may want to use something else than sed to set the platform to run on (like that, it would break as soon as someone introduces a Coq package with ubuntu in the name).

@Zimmi48 Zimmi48 added the enhancement New feature or request label Aug 11, 2021
@Zimmi48
Copy link
Member Author

Zimmi48 commented Aug 11, 2021

And one thing I didn't do but should be done is to give different names to workflows running on different platforms.

@Zimmi48
Copy link
Member Author

Zimmi48 commented Aug 11, 2021

we may want to make the list of platforms to run CI on configurable

This is all the more important given that for private repositories macOS runners cost 10 times more than Ubuntu runners and on public repositories, they are free but are capped to 5 concurrent runners while Ubuntu runners are capped to 20 concurrent runners. (This also means that enabling this in this repo will significantly slow down getting CI results.)

@Zimmi48
Copy link
Member Author

Zimmi48 commented Aug 11, 2021

Oops, I have wasted a lot of build power by accidentally opening this PR from my fork and therefore not having Cachix enabled. Therefore, some packages have been built over and over.

@Zimmi48 Zimmi48 closed this Aug 11, 2021
@Zimmi48 Zimmi48 deleted the enable-macos branch August 11, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate all CI jobs to also run on macOS.
1 participant